-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-4492] Remove unwanted tag transitions #4002
[FX-4492] Remove unwanted tag transitions #4002
Conversation
🦋 Changeset detectedLatest commit: c4176d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on temploy, looks great!
@toptal-anvil ping reviewers |
Co-authored-by: Aleksandr Shumilov <[email protected]>
FX-4492
Description
Remove the default transitions from all
Tag
components.I was not able to disable them in a single place (in theory, it should be possible to use
overrides
inPicassoProvider
, however, in practice it just didn't work at all, probably due to class overrides inside components).How to test
Screenshots
Before
deepin-screen-recorder_Select.area_20231120121350.mp4
After
deepin-screen-recorder_Select.area_20231120121139.mp4
Development checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?